-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A; B] and [A B] concatenation syntax (#187) #209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
+ Coverage 62.92% 63.83% +0.9%
=========================================
Files 48 48
Lines 3361 3473 +112
=========================================
+ Hits 2115 2217 +102
- Misses 1246 1256 +10
Continue to review full report at Codecov.
|
TODO: I suspect they are errors right now. |
With that corner case closed, We are using this syntax part in TensorFlowDiffEq.jl (@ChrisRackauckas) And it is hard to deploy tests against non-tagged versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
does #187
So that cool.
This could do with some code review (like all code).
It contains a
@goto
which is frowned upon by Dijkstra.Normally I want to use gotos to break out of nested loops, and then I immediately see that I want to refactor to be using a function and then can use return to breakout.
But this time I want to restart the loop from the beginning
One option would be to use a while loop and manage the index manually
But I don't think that is more readable.
One thing that is still pending is a general way for this to be dispatched to when one or more of the varargs is an
AbstractTensor
and one or more is not (but assumably can be converted).Right now this is accomplished by specialcasing the first two arguments.
So long as one of the first two arguments is an
AbstractTensor
then it is dispatched to correctly.I think that covers the vast majority of uses.
Maybe it is worth expanding to first 3? Beyond that doing it manually becomes cumbersome.
I could perhaps workout a metaprogramming loop and do it to the first dozen or so.
Not sure what to do with
hvcat
yet.I don't really know where it is used.