feat: improve key alignment efficiency #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve efficiency of aligning the key generator for the first time by starting at the theoretical maximum index instead of the minimum. This also comes with stability improvements because we are guaranteed to either 'overshoot' or match the actual index of the accessory since we're counting down. Overshooting is fine as long as the timestamp is correct because it means we will also overshoot our theoretical maximum index compared to the actual value, and since we're once again counting down from this value we're guaranteed to include the actual index in our search and obtain the latest report.