Use JSON logging by default #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the option to choose which logging format you want to use. The former unstructured log is still available but the new default is a structured log in the form of JSON. Exceptions still behave the same as before. Maybe some day they will also be in JSON format. Additionally, there is now a dedicated log line for every incoming HTTP request. The log line mentioning that a file will be scanned was set to debug level to reduce the amount of useless logs in day2day opertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the option to choose which logging format you want to
use. The former unstructured log is still available but the new default
is a structured log in the form of JSON.
Exceptions still behave the same as before. Maybe some day they will
also be in JSON format.
Additionally, there is now a dedicated log line for every incoming
HTTP request.
The log line mentioning that a file will be scanned was set to debug
level to reduce the amount of useless logs in day2day opertions.
Closes #25.