New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Error with "--" within a comment block #216

Closed
thomasjenkins opened this Issue Jul 28, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@thomasjenkins
Contributor

thomasjenkins commented Jul 28, 2016

If a double dash (--) appears within a set of tags inside of a ZPT markup comment block an "Unexpected end tag." ParseError is thrown. The unexpected tag in the error message is the first closing tag after the double dash. However, a double dash not enclosed by tags does not throw an error.

<!--!
  <div>
    --
  </div>
-->

Results in:

chameleon.exc.ParseError: chameleon.exc.ParseError: Unexpected end tag.

 - String:     "</div>"

However, the following parses without issue.

<!--!
  <div>
  </div>
  --
-->

@malthe malthe added the core label Jul 28, 2016

@malthe malthe added the cantfix label Dec 5, 2016

@malthe

This comment has been minimized.

Show comment
Hide comment
@malthe

malthe Dec 5, 2016

Owner

This has been dealt with in f2cad59 in that actually, double hyphen is not allowed inside an XML comment.

Owner

malthe commented Dec 5, 2016

This has been dealt with in f2cad59 in that actually, double hyphen is not allowed inside an XML comment.

@malthe malthe closed this Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment