compilation error #88

Closed
fafhrd91 opened this Issue Jan 25, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@fafhrd91

i'm not sure if this bug should be fixed in chameleon or in template

this code generates error:

    <p i18n:translate="description-contentrules-mailsub">
        Some content in the subject, email source, email recipient and message
        may be replaced with "${}" variables from the table below.
    </p>

https://github.com/plone/plone.app.contentrules/blob/master/plone/app/contentrules/actions/templates/mail.pt

Traceback (innermost last): 

    Module ZPublisher.Publish, line 126, in publish 
    Module ZPublisher.mapply, line 77, in mapply 
    Module ZPublisher.Publish, line 46, in call_object 
    Module zope.formlib.form, line 800, in __call__ 
    Module zope.formlib.form, line 790, in render 
    Module Products.Five.browser.pagetemplatefile, line 125, in __call__ 
    Module Products.Five.browser.pagetemplatefile, line 59, in __call__ 
    Module zope.pagetemplate.pagetemplate, line 126, in pt_render 
    Warning: Compilation failed 
    Warning: exceptions.KeyError: 'variable' 
@malthe

This comment has been minimized.

Show comment Hide comment
@malthe

malthe Jan 26, 2012

Owner

I suppose we should simply ignore the following two: ${} and ${...} – so that it's easy to document such; perhaps even ${<some name>}.

Owner

malthe commented Jan 26, 2012

I suppose we should simply ignore the following two: ${} and ${...} – so that it's easy to document such; perhaps even ${<some name>}.

@eleddy

This comment has been minimized.

Show comment Hide comment
@eleddy

eleddy Aug 26, 2012

This bug breaks content rules with OOB plone. I will attempt to patch for now in that template since so many people are using this code but I don't know where else this could be in Plone so mid term a fix would be nice. Will cross reference with chameleon plip.

eleddy commented Aug 26, 2012

This bug breaks content rules with OOB plone. I will attempt to patch for now in that template since so many people are using this code but I don't know where else this could be in Plone so mid term a fix would be nice. Will cross reference with chameleon plip.

@eleddy

This comment has been minimized.

Show comment Hide comment
@eleddy

eleddy Aug 26, 2012

fix in p.a.content rules at plone/plone.app.contentrules@d8dec97 . Happy to remove if a nicer fix comes in.

eleddy commented Aug 26, 2012

fix in p.a.content rules at plone/plone.app.contentrules@d8dec97 . Happy to remove if a nicer fix comes in.

malthe added a commit that referenced this issue Oct 8, 2012

@malthe

This comment has been minimized.

Show comment Hide comment
@malthe

malthe Oct 8, 2012

Owner

Should be fixed now.

Owner

malthe commented Oct 8, 2012

Should be fixed now.

@malthe malthe closed this Oct 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment