Remove Py2.4 compatibility code? #95

Closed
xiaq opened this Issue Feb 12, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@xiaq

xiaq commented Feb 12, 2012

Python 2.4 is not supported anyway.

@malthe

This comment has been minimized.

Show comment
Hide comment
@malthe

malthe Feb 12, 2012

Owner

What parts of the code is this? I only see 2.5-related compatibility code in there.

Owner

malthe commented Feb 12, 2012

What parts of the code is this? I only see 2.5-related compatibility code in there.

@xiaq

This comment has been minimized.

Show comment
Hide comment
@xiaq

xiaq Feb 12, 2012

ast24.py and related code. Grepping for ast24:

~/src/chameleon/src/chameleon% grep ast24 -R .
./utils.py: from chameleon import ast24 as _ast
./zpt/template.py: from chameleon import ast24 as ast
./zpt/program.py: from chameleon import ast24 as ast
./codegen.py: from chameleon import ast24 as ast
./astutil.py: from chameleon import ast24 as ast

xiaq commented Feb 12, 2012

ast24.py and related code. Grepping for ast24:

~/src/chameleon/src/chameleon% grep ast24 -R .
./utils.py: from chameleon import ast24 as _ast
./zpt/template.py: from chameleon import ast24 as ast
./zpt/program.py: from chameleon import ast24 as ast
./codegen.py: from chameleon import ast24 as ast
./astutil.py: from chameleon import ast24 as ast

@malthe

This comment has been minimized.

Show comment
Hide comment
@malthe

malthe Feb 12, 2012

Owner

That's actually still there to make sure the Python 2.5 ast module works like its successors. On 2.4 it wasn't there at all, but 2.5 only implements some parts of it.

Owner

malthe commented Feb 12, 2012

That's actually still there to make sure the Python 2.5 ast module works like its successors. On 2.4 it wasn't there at all, but 2.5 only implements some parts of it.

@xiaq

This comment has been minimized.

Show comment
Hide comment
@xiaq

xiaq Feb 12, 2012

Better named ast25 then :) I suppose I won't be the last one to be confused.

xiaq commented Feb 12, 2012

Better named ast25 then :) I suppose I won't be the last one to be confused.

malthe added a commit that referenced this issue Oct 11, 2012

@malthe malthe closed this Oct 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment