Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process exits and yori freezes when using with Windows Terminal #29

Closed
igitur opened this issue Mar 19, 2020 · 2 comments
Closed

Process exits and yori freezes when using with Windows Terminal #29

igitur opened this issue Mar 19, 2020 · 2 comments

Comments

@igitur
Copy link

@igitur igitur commented Mar 19, 2020

Hi,

So I followed the instructions by Scott Hanselman to install Yori and use it with Windows Terminal.

For the most part, it works great, but every now and then, when I hit Ctrl-C to kill a process, yori also freezes up. For example, simply hitting Ctrl-C while pinging something:
image

I don't have this problem with Yori's own terminal, just when I use Windows Terminal. Maybe this is not a Yori issue, but rather a Windows Terminal, but I don't experience it with any of the other shells that I also use in Windows Terminal, e.g. PowerShell or msys2.

@malxau

This comment has been minimized.

Copy link
Owner

@malxau malxau commented Mar 19, 2020

Can I ask which version of Windows Terminal you have, and which version of Yori you have? I've been trying to reproduce this, so far without success.

What I've tried:

  • With WT 0.10.761.0 and 0.9.433.0
  • With Yori 1.20 and the current testing build
  • Copied Scott's profile. (I had to remove the color scheme, but that seems unlikely to be related)
  • Ran ping and hit both Ctrl+C and Ctrl+Break

I haven't been able to observe this behavior at all. Can you think of anything else that I can try?

One challenging case in Yori that may be related but I don't see it doing quite the same thing is nested shells. Yori first asks child processes nicely to die, and if they don't, it's willing to terminate them. This is frequently nice from a user's point of view, but when nested instances are present it can end up killing a child instance. But getting the output you showed here would require a parent instance that launches a child instance for interactive use and the parent will terminate as soon as the child terminates (ie., yori /c yori type thing.)

@igitur

This comment has been minimized.

Copy link
Author

@igitur igitur commented Mar 20, 2020

Ah, yes, it was a nested instance, but not deliberately. I had installed yori via the scoop package manager, which executes yori via a shim layer. I now changed my Windows Terminal to execute the underlying yori.exe directly and that solves my problem. Thanks so much.

@igitur igitur closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.