Breadcrumbs behaving badly

[mamacdon]

1. Go the Navigator page in Orionode.
2. Drill into one of your projects.
3. Observe the breadcrumb (underneath the top nav banner). It looks like this:

Orion Node Content / MyProject / MyProject

The last segment is always listed twice. If you drill deeper into further folders, it'll look like this:

Orion Node Content / MyProject / folder / folder

The problem is probably due a flaw in Orionode's algorithm for generating the Parents array of the file API. Likely culprits are file.js and fileUtils.js.

Also I noticed that the problem is triggered by requesting a directory resource with a trailing slash after it. For example, GET /file/MyProject/?depth=1 has the bad Parents array, but GET /file/MyProject?depth=1 behaves as expected. When Orionode generates a directory listing it always uses the trailing slash to indicate a directory (as expected), so you see this problem all the time.

[kobrigo]

Hi Mark,
I would like to work on this one. It will allow me to get into the code of orionode.

[kobrigo]

I have debugged it and found the place where the link is not being build right. On the navigator.
It's under navigatorRenderer.js line 92.
It actually being taken from the ChildrenLocation which is build by the server.

In the BreadCrums the building is done by taking the Parents array and in each Parent the ChildrenLocation is build without the leading "/"

I wonder... I can apply a fix to the client.... but do you think this should be done in the server?
should the server support both kinds of links (with the trailing "/" and also without) when opened?

There is inconsistency with the ChildrenLocation property.

Should the parent array items should include the ChildrenLocation with the leading "/" to indicate this is a directory (as you mentioned that is what should be expected) but then I guess there would be other places in the code to fix too.

[libingw]

Hi, Kobrigo:
Thanks for the comment. Mark is on vacation right now.
I just transferred this issue to bugzilla. https://bugs.eclipse.org/bugs/show_bug.cgi?id=396646.
I will take a look at the tricks you mentioned.
Actually our code base is moved to Orion client repo as well. We still have a little dependency work to add there then you can pull code from there to run the node server as you did before. I will keep you updated.
And, the issues will be tracked in bugzilla from now. You can watch other issue from here
https://bugs.eclipse.org/bugs/buglist.cgi?classification=Eclipse&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Node&product=Orion.

By the way, do you have a bugzilla id? So that I can cc you on the bug.