Shell: can't use commands on a file until doing ls

[mamacdon]

1. Open the shell page.
2. cd to some directory that has files in it.
3. Try to run a command that takes a filename as input. For example: node start foo.js (where foo.js is in your CWD).
4. The shell won't let you enter the command.
5. Type ls, then try the command again. Now it works.

It seems you need to prefill the shell's file list by doing ls before filename completions will work.

Link to bug @ orion.client Bugzilla

[BorisKozo]

It could be nice if one of the non critical bugs is assigned to us (when legally possible) so that we can dive into the code a little deeper.

[mamacdon]

Hey Boris. If you'd like to start looking at this, go right ahead. (GitHub won't let me assign it to you, but don't let that stop you from diving in -- we just can't merge in any pull requests until we get the legal jazz worked out.)

I suspect the actual bug is in the orion.client library that we pick up from Orion proper, so if you find a fix, you can actually contribute it back to the upstream orion.client (which is fully-open for contributions) and Orionode can just merge it in.

Good places to start debugging are shellPageFileService.js and shellPage.js in the lib/orion.client/bundles/org.eclipse.orion.client.core/web/shell/plugins folder.

[BorisKozo]

After some investigation I found a possible fix:
in shellPageFileService.js line 241 should be
if (node.Directory === undefined && node.ChildrenLocation) {

Since the Directory property may be set earlier it seems wrong to set it again based solely on the ChildrenLocation property.

Could you please check it?

Thanks,
Boris.

[libingw]

Hi, Boris. Thanks for the patch. Mark is on vacation now so I will have a look at this.
By the way, we are pushing all the code to Orion client repo now.
I am transferring this issue to bugzilla. (https://bugs.eclipse.org/bugs/show_bug.cgi?id=396644)
If you are interested you can also run this query to see all other open issues.
https://bugs.eclipse.org/bugs/buglist.cgi?classification=Eclipse&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Node&product=Orion

[BorisKozo]

Hi,
Note that there is already a bugzilla bug on it at https://bugs.eclipse.org/bugs/show_bug.cgi?id=394580
Also, could you link to the patch that solved it. I want to see the actual fix made.

Thanks,
Boris.

[libingw]

Hi, Boris:
Thanks for the catch. Actually I opened the old one as well. just forgot. I've made that old one duplicated.
So when I push the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=396644, I will put commit link of our git repo. You will easily see the patch there.
BTW, do you have a bugzilla ID? so I can cc to you.

I am still transferring other issues to bugzilla now. Just noticed you have some comments on #10.
I will update you very soon.
Thanks again,
Libing

[libingw]

Hi, Boris:
Just realized that issue10 was commented by another person. Sorry for the confusion.

Libing

[BorisKozo]

Hi,
I don't have an id and I can't seem to find a way to create one.

[libingw]

Hi, Boris:
Go to https://bugs.eclipse.org/bugs/ and create a new account. The use this https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Orion&version=1.0 to report a bug. Please select node as component in the page.