Use custom function to properly parse matchspec #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
solv-conda-spec
branch
from
e77ba7a
to
3778470
Compare
AntoinePrv
force-pushed
the
solv-conda-spec
branch
from
3778470
to
e8d6b3d
Compare
AntoinePrv
requested review from
wolfv and
JohanMabille
and removed request for
wolfv
Klaim
approved these changes
Apr 3, 2023
JohanMabille
reviewed
Apr 3, 2023
| @@ -18,7 +19,7 @@ namespace mamba | |||
| public: | |||
|
|
|||
| MatchSpec() = default; | |||
| MatchSpec(const std::string& i_spec); | |||
| MatchSpec(std::string_view i_spec); | |||
There was a problem hiding this comment.
Do we need to authorize implicit conversions?
There was a problem hiding this comment.
This was the current behavior. Leaving a note to change it when this is worked on.
| auto x = custom_multichannels.find(needle.name()); | ||
| if (x != custom_multichannels.end()) | ||
| { | ||
| for (auto el : (x->second)) |
There was a problem hiding this comment.
Nitpicking:
return std::find_if(x->second.begin(), x->second.end(), [chan](const auto& e) {
return make_channel(el) == *chan; }) != x->second.end();There was a problem hiding this comment.
This function was moved. I'm leaving it as it is since it needs re-work as well.
JohanMabille
approved these changes
Apr 3, 2023
This was referenced Apr 15, 2023
2 tasks
|
Hey team, JFYI, we have found that this PR introduced some changes in the solver behaviour. More details at #2486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2302