Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
hlsl bgfx screen chain making screen red #4396
As of 0.204 enabling hlsl screen chain with bgfx on Fedora 29 x86_64 makes the video red. Here is the mame -verbose output:
The issue is caused by src/osd/modules/render/bgfx/shaders/chains/hlsl/fs_chroma.sc
In line 26 the XYZ_TO_sRGB matrix has to be transposed:
Can somebody with more knowledge about the bgfx shader system please apply this change?
The shader can be build with the following command:
Just "make shaders" will produce a cryptic error message when compiling the xbr chain. I failed to identify the error.
I experience the same issue on Ubuntu 18.04 running 0.205.
The game is started with this command:
Transposing the matrix in
I will create a PR with the change but it will need to be reviewed by someone familiar with the bgfx and hlsl systems.