From 13ceed724ca25bce5b40b9f31b00600f4746924f Mon Sep 17 00:00:00 2001 From: Jamie McCadden Date: Fri, 29 Mar 2024 14:18:07 +0000 Subject: [PATCH 1/3] strtdriv: fixed incorrect brake pedal port mapping in harddriv.cpp Fixed wrongly mapped brake pedal input from 8ADC:6 to 8ADC:2 and swapped the Voice Mic function which is unused from 8ADC:2 to 8ADC:6 to avoid any conflict/loss of functionality. Steering input still needs to be fixed (if you turn to the far left of right the centre point of the steering wheel will shift and constantly pull the wheel in the opposite direction) Hard Drivin's Airborne has the same problem. Will try to fix that if I can and update the code here on GitHub. --- src/mame/atari/harddriv.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mame/atari/harddriv.cpp b/src/mame/atari/harddriv.cpp index 73ad1832830b4..45ea05e3e0e9a 100644 --- a/src/mame/atari/harddriv.cpp +++ b/src/mame/atari/harddriv.cpp @@ -1312,8 +1312,8 @@ static INPUT_PORTS_START( strtdriv ) PORT_START("mainpcb:8BADC.1") /* b00000 - 8 bit ADC 1 */ PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED ) - PORT_START("mainpcb:8BADC.2") /* b00000 - 8 bit ADC 2 - voice mic */ - PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED ) + PORT_START("mainpcb:8BADC.2") /* b00000 - 8 bit ADC 2 - brake */ + PORT_BIT( 0xff, 0x00, IPT_PEDAL2 ) PORT_SENSITIVITY(25) PORT_KEYDELTA(40) PORT_NAME("Brake") PORT_START("mainpcb:8BADC.3") /* b00000 - 8 bit ADC 3 - volume */ PORT_BIT( 0xff, 0x80, IPT_UNUSED ) @@ -1324,8 +1324,8 @@ static INPUT_PORTS_START( strtdriv ) PORT_START("mainpcb:8BADC.5") /* b00000 - 8 bit ADC 5 - canopy */ PORT_BIT( 0xff, 0x80, IPT_UNUSED ) - PORT_START("mainpcb:8BADC.6") /* b00000 - 8 bit ADC 6 - brake */ - PORT_BIT( 0xff, 0x00, IPT_PEDAL2 ) PORT_SENSITIVITY(25) PORT_KEYDELTA(40) PORT_NAME("Brake") PORT_REVERSE + PORT_START("mainpcb:8BADC.6") /* b00000 - 8 bit ADC 6 - voice mic */ + PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED ) PORT_START("mainpcb:8BADC.7") /* b00000 - 8 bit ADC 7 - seat adjust */ PORT_BIT( 0xff, 0x80, IPT_UNUSED ) From abded5e9d29d41b97d9a6843ff4d941d62dcdb8c Mon Sep 17 00:00:00 2001 From: Jamie McCadden Date: Fri, 29 Mar 2024 15:38:37 +0000 Subject: [PATCH 2/3] Fixed brake ADC channel mapping for strtdriv and specified that the "voice mic" ADC channel is a placeholder that has not been tested or verified as working in harddriv.cpp Swapped brake input from ADC channel 6 to ADC channel 2 to fix the broken brake input functionality. Swapped "voice mic" from ADC channel 2 to ADC channel 6 as a placeholder only as it has NOT been tested or verified as working yet and may be unused. --- src/mame/atari/harddriv.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mame/atari/harddriv.cpp b/src/mame/atari/harddriv.cpp index 45ea05e3e0e9a..52a30ca37b81b 100644 --- a/src/mame/atari/harddriv.cpp +++ b/src/mame/atari/harddriv.cpp @@ -1324,6 +1324,7 @@ static INPUT_PORTS_START( strtdriv ) PORT_START("mainpcb:8BADC.5") /* b00000 - 8 bit ADC 5 - canopy */ PORT_BIT( 0xff, 0x80, IPT_UNUSED ) + /* Placeholder ADC port for voice mic, NOT tested or verified! */ PORT_START("mainpcb:8BADC.6") /* b00000 - 8 bit ADC 6 - voice mic */ PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED ) From 7cd14fc933133dcb4716dff3bacfa72b9777ad71 Mon Sep 17 00:00:00 2001 From: Jamie McCadden Date: Fri, 29 Mar 2024 16:06:36 +0000 Subject: [PATCH 3/3] Updated the voice mic ADC input comment to be more streamlined in harddriv.cpp Updated the original comment on the untested/unverified voice mic ADC input instead of adding a extra comment to the code above it as suggested by rb6502 and cuavas. --- src/mame/atari/harddriv.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mame/atari/harddriv.cpp b/src/mame/atari/harddriv.cpp index 52a30ca37b81b..45a39824363ca 100644 --- a/src/mame/atari/harddriv.cpp +++ b/src/mame/atari/harddriv.cpp @@ -1324,8 +1324,7 @@ static INPUT_PORTS_START( strtdriv ) PORT_START("mainpcb:8BADC.5") /* b00000 - 8 bit ADC 5 - canopy */ PORT_BIT( 0xff, 0x80, IPT_UNUSED ) - /* Placeholder ADC port for voice mic, NOT tested or verified! */ - PORT_START("mainpcb:8BADC.6") /* b00000 - 8 bit ADC 6 - voice mic */ + PORT_START("mainpcb:8BADC.6") /* b00000 - 8 bit ADC 6 - ADC input for voice mic? Not verified */ PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED ) PORT_START("mainpcb:8BADC.7") /* b00000 - 8 bit ADC 7 - seat adjust */