t11: handle unaligned accesses to I/O page. #14347
Merged
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain devices on bk, uknc require this, as they do not handle the WTBT bus signal and always decode full address.
cuavas
reviewed
Oct 30, 2025
Comment on lines
+150
to
+151
| else if (flags & UNALIGNED_BYTE) | ||
| return m_program.read_byte(addr); |
There was a problem hiding this comment.
Does this path actually work? It looks like it causes it to always do a byte access, even if the address is word-aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain devices on bk, uknc require this, as they do not handle the WTBT bus signal and always decode full address.