ef9345: Fix insert flag for the ts9347 variant in 80 columns mode #14422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an undocumented behavior that was found here for the TS9347 variant of this video chip: https://github.com/fabio-d/minitel-ef9345-testsuite/blob/f82aa4b14094affd49d9b237aa856b8e8690ef50/tests/test_colors.py#L372-L377.
The datasheet of the TS9347 describes the same mechanism as the EF9345 with regards to where the value of the insert bit comes from: either
DOR[7]orDOR[3], depending on the value ofA[0].Instead, it has been found experimentally that the insert bit corresponds to just
A[0]andDOR[7]has a completely unrelated function.