Skip to content

sega/model2: limit microtexture blend factor to 127/256 #14439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
+4 −12
Merged

sega/model2: limit microtexture blend factor to 127/256 #14439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/mame/sega/model2_v.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,15 +845,7 @@ void model2_renderer::model2_3d_render(triangle *tri, const rectangle &cliprect)
tri->v[2].pv = tri->v[2].pv * tri->v[2].pz * (1.0f / 8.0f);
}

switch (renderer)
{
case 0:
case 1:
case 2:
case 3:
render_triangle<3>(vp, m_render_callbacks[renderer], tri->v[0], tri->v[1], tri->v[2]);
break;
}
render_triangle<3>(vp, m_render_callbacks[renderer], tri->v[0], tri->v[1], tri->v[2]);
}

/*
Expand Down
6 changes: 3 additions & 3 deletions src/mame/sega/model2rd.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ void model2_renderer::draw_scanline_tex(int32_t scanline, const extent_t &extent
float dvoz = extent.param[2].dpdx;

// calculate maximum mipmap level from texture dimensions; we go down to 2x2
s32 max_level = (f2u(float(std::min(object.texwidth, object.texheight))) >> 23) - 128;
s32 max_level = 30 - count_leading_zeros_32(std::min(object.texwidth, object.texheight));

colorbase = state->m_palram[(colorbase + 0x1000)] & 0x7fff;

Expand Down Expand Up @@ -265,9 +265,9 @@ void model2_renderer::draw_scanline_tex(int32_t scanline, const extent_t &extent
}
else if (object.utex && mml < 0)
{
// microtexture; blend up to 50%
// microtexture; blend up to almost 50%
u32 t2 = fetch_bilinear_texel<Translucent>(object, -1, u, v);
s32 frac = std::min(-mml >> object.utexminlod, 128);
s32 frac = std::min(-mml >> object.utexminlod, 127);
t = LERP(t, t2, frac);
}

Expand Down
Loading