Skip to content

Elaut Megacrane - #14441

Merged
Osso13 merged 15 commits into
mamedev:masterfrom
stonedDiscord:elaut
Oct 31, 2025
Merged

Osso13 merged 15 commits into
mamedev:masterfrom
stonedDiscord:elaut

Conversation

@stonedDiscord

Copy link
Copy Markdown
Contributor

New systems marked not working

Elaut Megacrane [stonedDiscord]

@Osso13 Osso13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, just some advice

Comment thread src/mame/skeleton/megacrane.cpp Resolved
: driver_device(mconfig, type, tag)
, m_maincpu(*this, "maincpu")
, m_spi(*this, "nvram")
, m_ymz(*this, "ymz")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to add device pointers if you don't plan to use them outside of the machine config and the memory maps

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect there to be a bit more work on the YMZ, I haven't figured out all traces yet and I can't hear any music either.

Comment thread src/mame/skeleton/megacrane.cpp Resolved
Comment thread src/mame/skeleton/megacrane.cpp Resolved
@Osso13
Osso13 merged commit 60c9a1e into mamedev:master Oct 31, 2025
@stonedDiscord
stonedDiscord deleted the elaut branch November 1, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants