Repository navigation
Elaut Megacrane - #14441
Merged
Merged
Elaut Megacrane#14441
Conversation
Osso13
reviewed
Oct 31, 2025
Osso13
left a comment
Member
There was a problem hiding this comment.
Seems good to me, just some advice
| : driver_device(mconfig, type, tag) | ||
| , m_maincpu(*this, "maincpu") | ||
| , m_spi(*this, "nvram") | ||
| , m_ymz(*this, "ymz") |
Member
There was a problem hiding this comment.
you don't need to add device pointers if you don't plan to use them outside of the machine config and the memory maps
Contributor
Author
There was a problem hiding this comment.
I expect there to be a bit more work on the YMZ, I haven't figured out all traces yet and I can't hear any music either.
… blank lines due to my unclear comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New systems marked not working
Elaut Megacrane [stonedDiscord]