Skip to content

current Plug and Play work (SPG/GPL cleanups) #14508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2025
Merged

current Plug and Play work (SPG/GPL cleanups) #14508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1cc4e4b
current Plug and Play work (SPG/GPL cleanups + 2 new sets) - squashed…
Nov 11, 2025
234ea24
basic cleanups after viewing source changes in github PR
Nov 11, 2025
7504e44
add another TE dump
Nov 13, 2025
22a178e
added another 520 unit
Nov 13, 2025
1cfefaf
added a 620, might be in the wrong driver
Nov 13, 2025
048f325
added g3_800
Nov 13, 2025
1066bc1
add support for alt scramble xor
Nov 13, 2025
af77729
don't pass a bool here anymore
Nov 14, 2025
b086ba6
Merge branch 'mamedev:master' into 101125_2
mamehaze Nov 14, 2025
400dd00
remove VT changes
Nov 14, 2025
11a0c82
update device name
Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/src/machine.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3470,6 +3470,8 @@ if (MACHINES["SPG2XX"]~=null) then
MAME_DIR .. "src/devices/machine/generalplus_gpl951xx_soc.h",
MAME_DIR .. "src/devices/machine/spg_renderer.cpp",
MAME_DIR .. "src/devices/machine/spg_renderer.h",
MAME_DIR .. "src/devices/machine/gpl_renderer.cpp",
MAME_DIR .. "src/devices/machine/gpl_renderer.h",
}
end

Expand Down
17 changes: 9 additions & 8 deletions src/devices/machine/generalplus_gpl162xx_soc_video.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@ void gcm394_base_video_device::device_reset()
m_page3_addr_lsb = 0;
m_page3_addr_msb = 0;

m_renderer->set_video_spaces(m_cpuspace, m_cs_space, m_csbase);
m_renderer->set_video_spaces(m_cpuspace);
m_renderer->set_cs_video_spaces(m_cs_space, m_csbase);
}

uint32_t gcm394_base_video_device::screen_update(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect)
Expand Down Expand Up @@ -398,12 +399,12 @@ uint32_t gcm394_base_video_device::screen_update(screen_device &screen, bitmap_r

for (int i = 0; i < 4; i++)
{
m_renderer->draw_page(true, true, m_703a_palettebank, cliprect, scanline, i, m_page0_addr_msb, m_page0_addr_lsb, m_tmap0_scroll, m_tmap0_regs, mem, m_paletteram, m_rowscroll, 0);
m_renderer->draw_page(true, true, m_703a_palettebank, cliprect, scanline, i, m_page1_addr_msb, m_page1_addr_lsb, m_tmap1_scroll, m_tmap1_regs, mem, m_paletteram, m_rowscroll, 1);
m_renderer->draw_page(true, true, m_703a_palettebank, cliprect, scanline, i, m_page2_addr_msb, m_page2_addr_lsb, m_tmap2_scroll, m_tmap2_regs, mem, m_paletteram, m_rowscroll, 2);
m_renderer->draw_page(true, true, m_703a_palettebank, cliprect, scanline, i, m_page3_addr_msb, m_page3_addr_lsb, m_tmap3_scroll, m_tmap3_regs, mem, m_paletteram, m_rowscroll, 3);
m_renderer->draw_page(true, m_703a_palettebank, cliprect, scanline, i, m_page0_addr_msb, m_page0_addr_lsb, m_tmap0_scroll, m_tmap0_regs, mem, m_paletteram, m_rowscroll, 0);
m_renderer->draw_page(true, m_703a_palettebank, cliprect, scanline, i, m_page1_addr_msb, m_page1_addr_lsb, m_tmap1_scroll, m_tmap1_regs, mem, m_paletteram, m_rowscroll, 1);
m_renderer->draw_page(true, m_703a_palettebank, cliprect, scanline, i, m_page2_addr_msb, m_page2_addr_lsb, m_tmap2_scroll, m_tmap2_regs, mem, m_paletteram, m_rowscroll, 2);
m_renderer->draw_page(true, m_703a_palettebank, cliprect, scanline, i, m_page3_addr_msb, m_page3_addr_lsb, m_tmap3_scroll, m_tmap3_regs, mem, m_paletteram, m_rowscroll, 3);

m_renderer->draw_sprites(true, m_use_legacy_mode ? 2 : 1, m_703a_palettebank, highres, cliprect, scanline, i, sprites_addr, mem, m_paletteram, m_spriteram, -1);
m_renderer->draw_sprites(true, m_use_legacy_mode ? 2 : 1, m_703a_palettebank, highres, cliprect, scanline, i, sprites_addr, mem, m_paletteram, m_spriteram);
}

m_renderer->apply_saturation_and_fade(bitmap, cliprect, scanline);
Expand Down Expand Up @@ -749,7 +750,7 @@ void gcm394_base_video_device::sprite_7042_extra_w(uint16_t data)
// B = blend mode (0 = use 702a for blending, 1 = use individual sprite blending)
// C = co-ordinate mode
// E = sprite enable

//popmessage("extra modes %04x\n", data);
}

Expand Down Expand Up @@ -1156,7 +1157,7 @@ void gcm394_base_video_device::device_add_mconfig(machine_config &config)
PALETTE(config, m_palette).set_format(palette_device::xRGB_555, 256*0x10);
GFXDECODE(config, m_gfxdecode, m_palette, gfx);

SPG_RENDERER(config, m_renderer, 0);
GPL_RENDERER(config, m_renderer, 0);
}


4 changes: 2 additions & 2 deletions src/devices/machine/generalplus_gpl162xx_soc_video.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#pragma once

#include "spg_renderer.h"
#include "gpl_renderer.h"
#include "cpu/unsp/unsp.h"
#include "screen.h"
#include "emupal.h"
Expand Down Expand Up @@ -232,7 +232,7 @@ class gcm394_base_video_device : public device_t, public device_video_interface
bool m_use_legacy_mode; // could be related to the 'unused' bits in the palete bank select being set, but uncertain
bool m_disallow_resolution_control;

required_device<spg_renderer_device> m_renderer;
required_device<gpl_renderer_device> m_renderer;

address_space* m_cpuspace;
address_space* m_cs_space;
Expand Down
Loading
Loading