esq5505 Ensoniq VFX family layouts: Specify the bounds for each group. #14518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the bounds for each group. This fixes an issue where the VFX (non-SD)'s button area is stretched vertically, because it does not have the "System" label at the top, leaving an empty space.
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the bounds for each group in the Ensoniq VFX family layouts.
This fixes an issue where the VFX (non-SD)'s button area is stretched vertically, because it does not have the "System" label at the top, leaving an empty space that was not included in the bounds calculation. This resulted in the button area being stretched vertically to fill the space, and the buttons being taller than they should.
Before:
After:
