Skip to content

tecmo/gaiden.cpp: make tile scrolling consistent with hardware #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+34 −60
Open

tecmo/gaiden.cpp: make tile scrolling consistent with hardware #14594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 34 additions & 60 deletions src/mame/tecmo/gaiden.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,21 @@ see the input_ports definition below for details on the input bits
write:
07a002-07a003 sprite layer Y offset
07a100-07a101 text layer X scroll offset
07a104-07a105 text layer Y scroll
07a108-07a109 text layer Y scroll offset
07a10c-07a10d text layer X scroll
07a200-07a201 front layer X scroll offset
07a204-07a205 front layer Y scroll
07a208-07a209 front layer Y scroll offset
07a20c-07a20d front layer X scroll
07a300-07a301 back layer X scroll offset
07a304-07a305 back layer Y scroll
07a308-07a309 back layer Y scroll offset
07a30c-07a30d back layer X scroll
unknown writes during boot sequence and/or game start:
07a000, 07a004, 07a006, 07a100, 07a110, 07a200, 07a210, 07a300, 07a310
07a000, 07a004, 07a006, 07a110, 07a210, 07a310
Notes:
- The sprite Y size control is slightly different from gaiden/wildfang to
Expand Down Expand Up @@ -211,12 +214,6 @@ class drgnbowl_state : public driver_device
bitmap_ind16 m_tile_bitmap_tx;

// live
uint16_t m_bg_scroll_x = 0;
uint16_t m_bg_scroll_y = 0;
uint16_t m_fg_scroll_x = 0;
uint16_t m_fg_scroll_y = 0;
int8_t m_bg_offset_y = 0;
int8_t m_fg_offset_y = 0;
int8_t m_spr_offset_y = 0;

// configuration
Expand Down Expand Up @@ -274,17 +271,16 @@ class gaiden_state : public drgnbowl_state
void gaiden_map(address_map &map) ATTR_COLD;

private:
uint16_t m_tx_scroll_x = 0;
uint16_t m_tx_scroll_y = 0;
int8_t m_tx_offset_y = 0;

void irq_ack_w(uint16_t data);

void flip_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void txscrollx_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void txscrolly_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void txoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void txoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void fgoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void fgoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void bgoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void bgoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);
void sproffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask = ~0);

Expand Down Expand Up @@ -463,10 +459,6 @@ void gaiden_state::video_start()
// m_foreground->set_transparent_pen(0);
m_text_layer->set_transparent_pen(0);

m_background->set_scrolldy(0, 33);
m_foreground->set_scrolldy(0, 33);
m_text_layer->set_scrolldy(0, 33);

// set up sprites
m_screen->register_screen_bitmap(m_sprite_bitmap);
}
Expand Down Expand Up @@ -522,65 +514,62 @@ void gaiden_state::flip_w(offs_t offset, uint16_t data, uint16_t mem_mask)

void gaiden_state::txscrollx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_tx_scroll_x);
m_text_layer->set_scrollx(0, m_tx_scroll_x);
m_text_layer->set_scrollx(0, data & 0xff);
}

void gaiden_state::txscrolly_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_tx_scroll_y);
m_text_layer->set_scrolly(0, (m_tx_scroll_y - m_tx_offset_y) & 0xffff);
m_text_layer->set_scrolly(0, data & 0x1ff);
}

void drgnbowl_state::fgscrollx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_fg_scroll_x);
m_foreground->set_scrollx(0, m_fg_scroll_x);
m_foreground->set_scrollx(0, data & 0x3ff);
}

void drgnbowl_state::fgscrolly_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_fg_scroll_y);
m_foreground->set_scrolly(0, (m_fg_scroll_y - m_fg_offset_y) & 0xffff);
m_foreground->set_scrolly(0, data & 0x1ff);
}

void drgnbowl_state::bgscrollx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_bg_scroll_x);
m_background->set_scrollx(0, m_bg_scroll_x);
m_background->set_scrollx(0, data & 0x3ff);
}

void drgnbowl_state::bgscrolly_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
COMBINE_DATA(&m_bg_scroll_y);
m_background->set_scrolly(0, (m_bg_scroll_y - m_bg_offset_y) & 0xffff);
m_background->set_scrolly(0, data & 0x1ff);
}

void gaiden_state::txoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
m_text_layer->set_scrolldx(0xb2 - (data & 0xff), 0x4d - (data & 0xff));
}

void gaiden_state::txoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
if (ACCESSING_BITS_0_7)
{
m_tx_offset_y = data;
m_text_layer->set_scrolly(0, (m_tx_scroll_y - m_tx_offset_y) & 0xffff);
}
m_text_layer->set_scrolldy(data & 0xff, 0xff - (data & 0xff));
}

void gaiden_state::fgoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
m_foreground->set_scrolldx(0x3b2 - (data & 0x3ff), 0x14d - (data & 0x3ff));
}

void gaiden_state::fgoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
if (ACCESSING_BITS_0_7)
{
m_fg_offset_y = data;
m_foreground->set_scrolly(0, (m_fg_scroll_y - m_fg_offset_y) & 0xffff);
}
m_foreground->set_scrolldy(0x20 - (data & 0x1ff), 0x2ff - (data & 0x1ff));
}

void gaiden_state::bgoffsetx_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
m_background->set_scrolldx(0x3b2 - (data & 0x3ff), 0x14d - (data & 0x3ff));
}

void gaiden_state::bgoffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
if (ACCESSING_BITS_0_7)
{
m_bg_offset_y = data;
m_background->set_scrolly(0, (m_bg_scroll_y - m_bg_offset_y) & 0xffff);
}
m_background->set_scrolldy(0x20 - (data & 0x1ff), 0x2ff - (data & 0x1ff));
}

void gaiden_state::sproffsety_w(offs_t offset, uint16_t data, uint16_t mem_mask)
Expand Down Expand Up @@ -881,20 +870,11 @@ static const int raiga_jumppoints_other[0x100] =

void drgnbowl_state::machine_reset()
{
m_bg_scroll_x = 0;
m_bg_scroll_y = 0;
m_fg_scroll_x = 0;
m_fg_scroll_y = 0;
m_fg_offset_y = 0;
m_bg_offset_y = 0;
}

void gaiden_state::machine_reset()
{
drgnbowl_state::machine_reset();
m_tx_scroll_x = 0;
m_tx_scroll_y = 0;
m_tx_offset_y = 0;
m_spr_offset_y = 0;
}

Expand All @@ -914,20 +894,11 @@ void raiga_state::machine_reset()

void drgnbowl_state::machine_start()
{
save_item(NAME(m_bg_scroll_x));
save_item(NAME(m_bg_scroll_y));
save_item(NAME(m_fg_scroll_x));
save_item(NAME(m_fg_scroll_y));
save_item(NAME(m_fg_offset_y));
save_item(NAME(m_bg_offset_y));
}

void gaiden_state::machine_start()
{
drgnbowl_state::machine_start();
save_item(NAME(m_tx_scroll_x));
save_item(NAME(m_tx_scroll_y));
save_item(NAME(m_tx_offset_y));
save_item(NAME(m_spr_offset_y));
}

Expand Down Expand Up @@ -1013,12 +984,15 @@ void gaiden_state::gaiden_map(address_map &map)
map(0x07a000, 0x07a001).portr("SYSTEM");
map(0x07a002, 0x07a003).portr("P1_P2").w(FUNC(gaiden_state::sproffsety_w));
map(0x07a004, 0x07a005).portr("DSW");
map(0x07a100, 0x07a101).w(FUNC(gaiden_state::txoffsetx_w));
map(0x07a104, 0x07a105).w(FUNC(gaiden_state::txscrolly_w));
map(0x07a108, 0x07a109).w(FUNC(gaiden_state::txoffsety_w));
map(0x07a10c, 0x07a10d).w(FUNC(gaiden_state::txscrollx_w));
map(0x07a200, 0x07a201).w(FUNC(gaiden_state::fgoffsetx_w));
map(0x07a204, 0x07a205).w(FUNC(gaiden_state::fgscrolly_w));
map(0x07a208, 0x07a209).w(FUNC(gaiden_state::fgoffsety_w));
map(0x07a20c, 0x07a20d).w(FUNC(gaiden_state::fgscrollx_w));
map(0x07a300, 0x07a301).w(FUNC(gaiden_state::bgoffsetx_w));
map(0x07a304, 0x07a305).w(FUNC(gaiden_state::bgscrolly_w));
map(0x07a308, 0x07a309).w(FUNC(gaiden_state::bgoffsety_w));
map(0x07a30c, 0x07a30d).w(FUNC(gaiden_state::bgscrollx_w));
Expand Down
Loading