New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luaengine sol2 #1626

Merged
merged 6 commits into from Nov 3, 2016

Conversation

Projects
None yet
2 participants
@cracyc
Copy link
Member

cracyc commented Nov 2, 2016

Done as a PR for comment and compile testing.

@mmicko

This comment has been minimized.

Copy link
Member

mmicko commented Nov 2, 2016

This looks much better to me, and most important library is maintained,
luabridge is not and sol2 is best available solution right now

On Wed, Nov 2, 2016 at 6:16 PM, cracyc notifications@github.com wrote:

Done as a PR for comment and compile testing.

You can view, comment on, or merge this pull request online at:

#1626
Commit Summary

  • luaengine: convert to sol2 [Carl]
  • luaengine: use templated accessor for call_plugin (nw)
  • luaengine: add basic table return support (nw)
  • luaengine: safer (nw)
  • luaengine: bugfixes (nw)

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1626, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdKSLv5UZ0Q7Xt9JtkgJGeXnV_2H6Lcks5q6MV6gaJpZM4Knggo
.

@mmicko mmicko merged commit 3ee5564 into mamedev:master Nov 3, 2016

2 checks passed

continuous-integration/tea the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cracyc cracyc deleted the cracyc:luaengine_sol2 branch Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment