Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agat: split from apple2.cpp, implement basic agat7 hardware. #2146

Closed
wants to merge 1 commit into from

Conversation

@shattered
Copy link
Contributor

commented Mar 14, 2017

No description provided.

@rb6502

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

I like this in general, but I have some comments.

  1. Just create another subdevice for the agat7 that loads the proper ROM; making it a BIOS selection on the Disk II is completely wrong.
  2. Unless the video is truly 100% on a card like PCs, the video should be in mame/video rather than under a2bus. (And if it is on a card, load the chargen and other necessary ROMs as part of the card device instead of the driver).
************************************************************************/

#include "emu.h"
#include "includes/apple2.h"

This comment has been minimized.

Copy link
@ajrhacker

ajrhacker Mar 15, 2017

Contributor

It doesn't seem clear why this dependency should be necessary when the driver has been split and agat_state doesn't inherit from the apple2 driver class.

This comment has been minimized.

Copy link
@shattered

shattered Mar 16, 2017

Author Contributor

AY3600. I've not written native keyboard yet.

@shattered

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2017

Video is onboard, but CPU is on a card :)

Submitted new PR, #2153

@shattered shattered closed this Mar 16, 2017

@shattered shattered deleted the shattered:_5061f4a branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.