New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i386/pc_vga: save state fixes #2178

Merged
merged 4 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@moralrecordings
Contributor

moralrecordings commented Mar 23, 2017

  • VGA card now saves vga.dac to the state, as the MAME palette is clobbered periodically with data from here. Changed the type of vga.dac.colour to a flat uint8_t array seeing as save_item isn't struct-friendly. Fixes Liero.
  • Saved more VGA flags, including vga.miscellaneous_output, which despite the vague name is needed for reading from the ports.
  • Fixed an enum range check miss.
  • Saved more i386 flags required for 32-bit save states. Fixes Jump 'n Bump.

@ajrhacker ajrhacker merged commit d566381 into mamedev:master Mar 23, 2017

2 checks passed

continuous-integration/tea the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cuavas

This comment has been minimized.

Show comment
Hide comment
@cuavas

cuavas Mar 23, 2017

Member

The switch statements in the port 03c0 handlers are now unnecessary - you can just add vga.dac.state to the offset. This kind of thing should be caught in review before merging.

Member

cuavas commented on 1e5fda7 Mar 23, 2017

The switch statements in the port 03c0 handlers are now unnecessary - you can just add vga.dac.state to the offset. This kind of thing should be caught in review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment