New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games Master Cartridge slot device for the Color Computer #2307

Merged
merged 5 commits into from May 15, 2017

Conversation

Projects
None yet
3 participants
@tlindner
Contributor

tlindner commented May 14, 2017

Adds a new slot device to emulate the Games Master Cartridge developed by John Linville.

@npwoods

Channeling Vas :-)

Show outdated Hide outdated src/devices/bus/coco/coco_gmc.cpp
Show outdated Hide outdated src/devices/bus/coco/coco_gmc.cpp
Show outdated Hide outdated src/devices/bus/coco/coco_gmc.h
@npwoods

This comment has been minimized.

Show comment
Hide comment
@npwoods

npwoods May 14, 2017

Contributor

Took another look; am I reading it correctly whereby you only added the SLOT_INTERFACE to the CoCo 1/2 declaration, and the Multi-Pak declaration? If I'm reading things correctly, you wouldn't be able to mount this in the CoCo 3 driver without using a Multi-Pak

Contributor

npwoods commented May 14, 2017

Took another look; am I reading it correctly whereby you only added the SLOT_INTERFACE to the CoCo 1/2 declaration, and the Multi-Pak declaration? If I'm reading things correctly, you wouldn't be able to mount this in the CoCo 3 driver without using a Multi-Pak

@tlindner

This comment has been minimized.

Show comment
Hide comment
@tlindner

tlindner May 14, 2017

Contributor

You're right. It's isn't working under the CoCo 3. I thought the CoCo 3 inherited the slot devices from the CoCo, and never tested. What is the correct way to add this to the coco3?

Contributor

tlindner commented May 14, 2017

You're right. It's isn't working under the CoCo 3. I thought the CoCo 3 inherited the slot devices from the CoCo, and never tested. What is the correct way to add this to the coco3?

@tlindner

This comment has been minimized.

Show comment
Hide comment
@tlindner

tlindner May 14, 2017

Contributor

Oops. It's working fine on the CoCo 3 driver. I had the Becker port turned on and heard no sound. But once I turned it off everything was fine. Here is the funky command I must use with the multi pack:

./mame64 coco3 -ext multi -ext:multi:slot4 games_master -cart5 cocofest.rom

Contributor

tlindner commented May 14, 2017

Oops. It's working fine on the CoCo 3 driver. I had the Becker port turned on and heard no sound. But once I turned it off everything was fine. Here is the funky command I must use with the multi pack:

./mame64 coco3 -ext multi -ext:multi:slot4 games_master -cart5 cocofest.rom

@npwoods

This comment has been minimized.

Show comment
Hide comment
@npwoods

npwoods May 14, 2017

Contributor

Can you get it to work without the Multi-Pak? If I'm reading the source correctly, you probably cannot.

On that note, it is probably bad that these slot declarations have to be copied and pasted around like this.

Contributor

npwoods commented May 14, 2017

Can you get it to work without the Multi-Pak? If I'm reading the source correctly, you probably cannot.

On that note, it is probably bad that these slot declarations have to be copied and pasted around like this.

@tlindner

This comment has been minimized.

Show comment
Hide comment
@tlindner

tlindner May 15, 2017

Contributor

Yup. Work with and without multipak, CoCo 1/2 and 3.

Contributor

tlindner commented May 15, 2017

Yup. Work with and without multipak, CoCo 1/2 and 3.

@npwoods npwoods merged commit a46365d into mamedev:master May 15, 2017

2 checks passed

continuous-integration/tea the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cuavas

This comment has been minimized.

Show comment
Hide comment
@cuavas

cuavas May 15, 2017

Member

This can't possible pass validation tests. Please fix your device constructor.

Member

cuavas commented May 15, 2017

This can't possible pass validation tests. Please fix your device constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment