Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crt-geom-deluxe improvement #5049

Closed
wants to merge 1 commit into from
Closed

crt-geom-deluxe improvement #5049

wants to merge 1 commit into from

Conversation

@cgwg
Copy link
Contributor

@cgwg cgwg commented May 12, 2019

Modified crt-geom-deluxe to track the power-law fall-off for longer (up to 1024 frames). Ensured that the intensity falls to zero afterward.

Note that this is currently only compiled for GLSL. Someone with a Windows machine should generate the full set of shader targets before merging.

…up to 1024 frames). Ensured that the intensity falls to zero afterward.

Note that this is currently only compiled for GLSL.
@cuavas
Copy link
Member

@cuavas cuavas commented Nov 19, 2019

Bumping this since it's been sitting open for ages, and we've had a bunch of bgfx updates lately. Can someone set up to build all the shaders apply this?

@u-man74
Copy link

@u-man74 u-man74 commented Nov 19, 2019

I really wanted to do this, but the problem was that nobody could remember well enough, how to compile bgfx shaders. I know, that noone gives a fuck what i say, but please, if somebody is doing this, make a small tutorial how to compile that stuff. It was not hard, as long as i remember. At least people (like me) could try to make conversions of existing shaders. I can only recommend to create a own topic for shaders on MW. From time to time, there are contributions, but they get lost in the forum.

@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Nov 19, 2019

make shaders

Alternatively, to compile a specific chain subdir:

make shaders CHAIN=[dir]

@u-man74
Copy link

@u-man74 u-man74 commented Nov 19, 2019

Thanks Moogly. So easy, i cant believe that a few months ago, noone did remember this.

@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Nov 19, 2019

Yeah, I ended up having to go digging into the makefile. I could never remember whether it was make SHADERS=1 or make SHADERS or make shaders or what.

@u-man74
Copy link

@u-man74 u-man74 commented Nov 19, 2019

Somehow pity that this compiling step is needed, on the other side HLSL need that too. Maybe Firehawk could add this to the shader docs. I would like to compile this right away, but i will not be at home, for the next two weeks at least.

@rtissera
Copy link
Contributor

@rtissera rtissera commented Dec 21, 2020

This looks like an interesting improvement, what is missing to get it merged ?

@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Dec 21, 2020

Sorry, for some reason I completely forgot about this. please remind me on the 23rd of this month.

My working directory is not clean, so I cannot currently take point on this. However, once I reach a good stopping point on my HP Jornada 720 driver, I will be happy to actually deliver on this if someone reminds me.

@rtissera
Copy link
Contributor

@rtissera rtissera commented Dec 23, 2020

Kindly reminder to @MooglyGuy as per request !

@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Dec 23, 2020

Thanks! I'm nearing a good stopping point with my current changes, so I'll get to this sometime before the code freeze on Saturday.

@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Dec 23, 2020

The shader changes have been merged and committed, and the shaders have been recompiled and committed.

@MooglyGuy MooglyGuy closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants