Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes https://mametesters.org/view.php?id=7526
src/lib/formats/hxchfe_dsk.cppreproducibly creates a SEGV when writing HFE files. This is caused by an endless loop inhfe_format::generate_hfe_bitstream_from_track, writing beyond end-of-array atmame/src/lib/formats/hxchfe_dsk.cpp
Line 683 in 140ba51
The endless loop is caused by re-setting
cur_posat two occasions and re-setting the loop variable.This fix drops the reset of
cur_posresulting in a successful write of a mixed-density (track0 sd, others dd) HFE image.