Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgi_mips.xml: New additions #6899

Merged
merged 4 commits into from Jul 10, 2020
Merged

sgi_mips.xml: New additions #6899

merged 4 commits into from Jul 10, 2020

Conversation

@darkstar
Copy link
Contributor

@darkstar darkstar commented Jul 2, 2020

This PR adds the following new software list entries:

  • Hot Mix 5
  • Hot Mix 7
  • SupportFolio 10/96
  • SupportFolio 2/97
  • SupportFolio 4/97
  • SupportAdvantage 10/94
  • SupportAdvantage 6/95

It also renames some Hot Mix CDs to increase consistency.

Photos of the CDs will be added in the comments.

All CHDs are available here

@darkstar
Copy link
Contributor Author

@darkstar darkstar commented Jul 2, 2020

Here are pictures of the CDs for reference:
hot_mix_5_and_7

supportfolio_10_96

supportfolio_2_97

supportfolio_4_97

SupportAdvantage_10_94

SupportAdvantage_6_95

@darkstar darkstar force-pushed the darkstar:sgi_chds branch from b5f61c1 to 0e9d000 Jul 2, 2020
<software name="hotmix_8">
<description>Hot Mix Volume 8</description>
<description>Hot Mix 8</description>

This comment has been minimized.

@davide125

davide125 Jul 3, 2020
Contributor

Please don't rename these unless you can verify the actual label on the disc. Hot Mix discs are not labeled consistently -- some are "Hot Mix X", some "Hot Mix Volume X". We should keep the same name that's used on the disc.

This comment has been minimized.

@darkstar

darkstar Jul 3, 2020
Author Contributor

It's a bit different, they are not even renamed consistently within one disc. They are called "HotMix X" on the CD itself, "Hot Mix - Volume X" on the sleeve's spine, and "HotMix - Volume X" in the booklet for example. I figured it would be easier to have one consistent naming scheme.

I will change the PR to keep the descriptions as they were

This comment has been minimized.

@davide125

davide125 Jul 3, 2020
Contributor

Thanks! Yeah, it's a bit of a mess. I usually go by what's on the CDs themselves, as that seems to match what's on P/N and old price lists.

@darkstar darkstar force-pushed the darkstar:sgi_chds branch from 0e9d000 to 4ea1a70 Jul 3, 2020
@@ -1556,7 +1582,7 @@ license:CC0
<feature name="part_number" value="812-8101-008"/>
<!-- Origin: unknown -->
<diskarea name="cdrom">
<disk name="hot_mix_volume_8" sha1="ee725db3a52ff482e03b7806889763619f584859" />
<disk name="hot_mix_8" sha1="ee725db3a52ff482e03b7806889763619f584859" />

This comment has been minimized.

@davide125

davide125 Jul 3, 2020
Contributor

You'll wanna drop the file renames as well

This comment has been minimized.

@darkstar

darkstar Jul 3, 2020
Author Contributor

Yeah, I thought I'd leave those since that's what the user selects/enters (and not necessarily linked to the name shown on the CD) and I think it's more intuitive if it's all similar. But if you want I'll drop those as well

This comment has been minimized.

@davide125

davide125 Jul 3, 2020
Contributor

Yeah I'd rather not rename these. They won't show up in the UI afaik, it uses the description (for the set name) and the part name and part_id (if present) for the individual discs.

@darkstar darkstar force-pushed the darkstar:sgi_chds branch from 4ea1a70 to 4d295b7 Jul 3, 2020
@darkstar
Copy link
Contributor Author

@darkstar darkstar commented Jul 5, 2020

addressed the issues in the comments. If there's anything else that needs to be changed let me know

@Tafoid Tafoid merged commit 39d1b41 into mamedev:master Jul 10, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@darkstar darkstar deleted the darkstar:sgi_chds branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.