Add Monkey King 3B SoC skeleton and RS-70 system #6906
Merged
Conversation
Signed-off-by: David Shah <dave@ds0.me>
Signed-off-by: David Shah <dave@ds0.me>
Signed-off-by: David Shah <dave@ds0.me>
Signed-off-by: David Shah <dave@ds0.me>
Signed-off-by: David Shah <dave@ds0.me>
|
For a skeleton driver, this looks perfectly alright to me. |
|
Actually, there is one thing: I believe we prefer to try to keep parent ROM set names within 8 characters, still. Would you please rectify that? Something like rs70_748 would work fine. |
Signed-off-by: David Shah <dave@ds0.me>
|
Thanks, fixed. The 748 was a confusion on my part anyway, it should have been 648 in 1. |
|
When I do a Squash-and-Merge, what name or nickname would you like to be credited under? |
|
David Shah would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The Monkey King 3B is an emulation-oriented ARM-based SoC by Digital Media Cartridge, a company closely associated with AtGames. The Monkey King family is a successor to their Titan ARM-based SoCs.
The RS-70 is one of the systems using it, with 648 NES and Genesis games on NOR flash in a PS1-esque casing and HDMI output.
This is just the beginnings of the core, all it does so far is print the following debug messages before hanging, but at least that means the memory mapping is vaguely right:
I can't guarantee that I will be able to finish this given the uncertainties involved, but hopefully this starting point is useful, and I would appreciate feedback on the code style.