mw8080bw: multiple improvements to gunfight netlist audio #6958
Conversation
Model for transistors adjusted, replacing default NPN transistor model with a high-gain NPN transistor type that more closely resembles those used by the real Gun Fight sound circuits. This has a quite obvious effect on the shot sounds, and it seems the circuits were designed for this effect. Made all volume potentiometers user-adjustable; previously fixed at 50%. Replaced abstract model of noise generator with component-level one, including a model of the generator's zener diode. Zener noise is provided by an associated Gaussian white noise source running off a 48 kHz clock. Both the zener diode and Gaussian white noise source are component models recently added to the netlist library. Supply voltage to amplifying transistors tweaked downward from 16.5 volts to 16 volts, determined by properly analyzing power supply circuit and confirmed with a documented reference. Much more commentary describing the sound circuits' function and modeling issues.
|
Just trying to merge the improvements I've been working on. (Should have been able to complete this much sooner if I hadn't allowed myself to get sidetracked by worries over accuracy details that are arguably out of scope.) Performance is about the same as the original (4 x speedup unthrottled on my machine), but sound accuracy is better, the noise generator's actual workings are emulated better, potentiometers can be adjusted, and the comments are better structured and much more thorough in explaining the circuit's operation and issues in modeling it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Model for transistors adjusted, replacing default NPN transistor
model with a high-gain NPN transistor type that more closely
resembles those used by the real Gun Fight sound circuits. This
has a quite obvious effect on the shot sounds, and it seems the
circuits were designed for this effect.
Made all volume potentiometers user-adjustable; previously fixed
at 50%.
Replaced abstract model of noise generator with component-level
one, including a model of the generator's zener diode. Zener
noise is provided by an associated Gaussian white noise source
running off a 48 kHz clock. Both the zener diode and Gaussian
white noise source are component models recently added to the
netlist library.
Supply voltage to amplifying transistors tweaked downward from
16.5 volts to 16 volts, determined by properly analyzing power
supply circuit and confirmed with a documented reference.
Much more commentary describing the sound circuits' function and
modeling issues.