Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mw8080bw: multiple improvements to gunfight netlist audio #6958

Merged

Conversation

@colinhowell
Copy link
Contributor

@colinhowell colinhowell commented Jul 14, 2020

Model for transistors adjusted, replacing default NPN transistor
model with a high-gain NPN transistor type that more closely
resembles those used by the real Gun Fight sound circuits. This
has a quite obvious effect on the shot sounds, and it seems the
circuits were designed for this effect.

Made all volume potentiometers user-adjustable; previously fixed
at 50%.

Replaced abstract model of noise generator with component-level
one, including a model of the generator's zener diode. Zener
noise is provided by an associated Gaussian white noise source
running off a 48 kHz clock. Both the zener diode and Gaussian
white noise source are component models recently added to the
netlist library.

Supply voltage to amplifying transistors tweaked downward from
16.5 volts to 16 volts, determined by properly analyzing power
supply circuit and confirmed with a documented reference.

Much more commentary describing the sound circuits' function and
modeling issues.

Model for transistors adjusted, replacing default NPN transistor
model with a high-gain NPN transistor type that more closely
resembles those used by the real Gun Fight sound circuits. This
has a quite obvious effect on the shot sounds, and it seems the
circuits were designed for this effect.

Made all volume potentiometers user-adjustable; previously fixed
at 50%.

Replaced abstract model of noise generator with component-level
one, including a model of the generator's zener diode. Zener
noise is provided by an associated Gaussian white noise source
running off a 48 kHz clock. Both the zener diode and Gaussian
white noise source are component models recently added to the
netlist library.

Supply voltage to amplifying transistors tweaked downward from
16.5 volts to 16 volts, determined by properly analyzing power
supply circuit and confirmed with a documented reference.

Much more commentary describing the sound circuits' function and
modeling issues.
@colinhowell
Copy link
Contributor Author

@colinhowell colinhowell commented Jul 14, 2020

Just trying to merge the improvements I've been working on. (Should have been able to complete this much sooner if I hadn't allowed myself to get sidetracked by worries over accuracy details that are arguably out of scope.) Performance is about the same as the original (4 x speedup unthrottled on my machine), but sound accuracy is better, the noise generator's actual workings are emulated better, potentiometers can be adjusted, and the comments are better structured and much more thorough in explaining the circuit's operation and issues in modeling it.

@ajrhacker ajrhacker merged commit 3294e01 into mamedev:master Jul 15, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.