Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/autofire: don't save 2bytes cfg file (nw) #6960

Merged
merged 1 commit into from Jul 17, 2020

Conversation

@kunikunijp
Copy link
Contributor

@kunikunijp kunikunijp commented Jul 15, 2020

No description provided.

@rb6502 rb6502 merged commit 33fbb85 into mamedev:master Jul 17, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@kunikunijp kunikunijp deleted the kunikunijp:autofire-patch-1 branch Jul 17, 2020
@cuavas
Copy link
Member

@cuavas cuavas commented Jul 19, 2020

Wouldn’t it be better to check to see whether you have an empty dictionary rather than relying on an implementation detail like this? This screams of being a hack.

@kunikunijp kunikunijp restored the kunikunijp:autofire-patch-1 branch Jul 19, 2020
@kunikunijp
Copy link
Contributor Author

@kunikunijp kunikunijp commented Jul 19, 2020

Thank you. Fixed the code.
#6969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.