Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added netlist-based audio to early Cinematronics vector games #6979

Merged
merged 107 commits into from Jul 22, 2020
Merged

Conversation

@aaronsgiles
Copy link
Contributor

@aaronsgiles aaronsgiles commented Jul 21, 2020

  • Added netlist simulations for the following games: Space War, Barrier, Star Hawk, Speed Freak, Star Castle, War of the Worlds, Sundance, Tail Gunner, Rip Off, Armor Attack, Warrior, Solar Quest, Boxing Bugs. Removed previous samples-based sound. [Aaron Giles, Couriersud]

  • Added built-in minimal artwork for Warrior. [Aaron Giles]

  • Changed speaker maximum sample tracking to be based on new compile-time define SPEAKER_TRACK_MAX_SAMPLE instead of MAME_DEBUG. [Aaron Giles]

  • Modernized 74164 and 74393 netlist TTL devices. [Aaron Giles]

aaronsgiles added 30 commits May 9, 2020
…inematronics audio code to create separate devices for each sound board to make it easier for forthcoming work. Currently needs a lot of optimization work before it's ready for master.
…ericized input labels into the sound board so they can be consistent between boards and simplify the logging. Enabled wotw netlist, though it has errors still.
…is just the same as Star Castle but with swizzled input lines. Add a mechanism for swizzling the shiftreg upon latching.
…ust submitting for safekeeping. Speed Freak is super slow and Sundance crashes.
…g HLE. Simplifies the interface to the sound board, but has problems with synchronization on the fast writes. Left off by default.
…d reporting of re-definitions.
…ly works otherwise.
aaronsgiles added 21 commits Jul 11, 2020
… (the rest failed).
…ary minus in equations.
…o make them playable.
@aaronsgiles aaronsgiles requested review from couriersud, cuavas and rb6502 Jul 21, 2020
@MooglyGuy
Copy link
Contributor

@MooglyGuy MooglyGuy commented Jul 22, 2020

@aaronsgiles There are only three minor bits of feedback I have, none of which should be blockers for merging, but it would be nice to have them addressed before the Saturday code freeze.

  1. In some of the source files (namely the Cinematronics audio device, it looks like), you're using u8 in various places, but I've also seen some spots that use uint32_t. For consistency, it's preferred to have all one style or all the other. Since you've rewritten the majority of the file, it's up to you which one.

  2. I'm a little leery of compile-time defines, since it can and does lead to dead, unmaintained code. Being able to track clipping seems like a useful development feature. I would consider having a command-line enable flag.

  3. Having a hard-coded magic number of 100000 for the number of samples to reject is a bit eyebrow-raising. If possible, consider allowing the user to supply the number via the command line if the flag outlined in point 2 is supplied.

aaronsgiles added 2 commits Jul 22, 2020
@aaronsgiles aaronsgiles merged commit f23db5d into master Jul 22, 2020
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@aaronsgiles aaronsgiles deleted the aaron-nl branch Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.