From cf05f476db71faa25a307abb64ece0ff00c1b25e Mon Sep 17 00:00:00 2001 From: cam900 Date: Mon, 7 Sep 2020 06:19:48 +0900 Subject: [PATCH] seta2.cpp: Fix invisible pixel issue in horizontal zoom algorithm Add notes for background color --- src/mame/drivers/seta2.cpp | 2 +- src/mame/video/seta2.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mame/drivers/seta2.cpp b/src/mame/drivers/seta2.cpp index ea9f48dfb4c82..11e5bc66236b2 100644 --- a/src/mame/drivers/seta2.cpp +++ b/src/mame/drivers/seta2.cpp @@ -55,7 +55,7 @@ P0-145-1 2002 Trophy Hunting - Bear & Moose (test) Sammy - Fix some graphics imperfections (e.g. color depth selection, "tilemap" sprites) [all done? - NS] - I added a kludge involving a -0x10 yoffset, this fixes the lifeline in myangel. I didn't find a better way to do it without breaking pzlbowl's title screen. -- 1 rightmost pixel columns are not drawn when zoomed +- Background color is not verified gundamex: - slowdowns, music tempo is incorrect diff --git a/src/mame/video/seta2.cpp b/src/mame/video/seta2.cpp index d5f667667020a..e165212cf96fb 100644 --- a/src/mame/video/seta2.cpp +++ b/src/mame/video/seta2.cpp @@ -321,7 +321,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli uint16_t* dest = &bitmap.pix16(screenline); int minx = cliprect.min_x << 16; - int maxx = cliprect.max_x << 16; + int maxx = (cliprect.max_x + 1) << 16; if (xzoom < 0x10000) // shrink { @@ -337,7 +337,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli uint8_t pen = (source[column++] & gfx_mask) >> gfx_shift; - if (sx >= minx && sx <= maxx) + if (sx >= minx && sx < maxx) { int realsx = sx >> 16; @@ -379,7 +379,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli { uint8_t pen = (source[column] & gfx_mask) >> gfx_shift; - if (sx >= minx && sx <= maxx) + if (sx >= minx && sx < maxx) { int realsx = sx >> 16;