Apple IIgs - don't flag "p" as a keypad character#7771
Closed
ksherlock wants to merge 1 commit intomamedev:masterfrom
Closed
Apple IIgs - don't flag "p" as a keypad character#7771ksherlock wants to merge 1 commit intomamedev:masterfrom
ksherlock wants to merge 1 commit intomamedev:masterfrom
Conversation
This also applies to `, [, and ]. The incorrect keypad flag causes some programs (Spectrum, for example) to treat 'p' as a function key. There actually isn't a standard keycode-p key but keycode-o is F12 and keycode-q is F15
Contributor
|
I have been struggling to get to the bottom of this bug for the past several months! It's made both Spectrum and Marlene unusable under MAME! In fact, I was just now typing up an issue report about it. Thank you so much @ksherlock ! |
Contributor
|
This was hand merged in 9967ab0 due to conflicts when I added the keypad = key (and happened to notice this issue while I was doing it). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'p' (0x39) is incorrectly being flagged as a keypad character. This also applies to `, [, and ].
The keypad flag causes some programs (Spectrum, for example) to treat 'p' as a function key since all function/extended keys are encoded via their raw ADB code and the keypad bit.