From 5156744123e35c4bc1324b38fcb064d53a0a3416 Mon Sep 17 00:00:00 2001 From: sasuke-arcade <58130089+sasuke-arcade@users.noreply.github.com> Date: Thu, 13 May 2021 02:21:14 +0900 Subject: [PATCH 1/2] cyclemb.cpp: Remove MACHINE_IMPERFECT_SOUND flags I think Cycle Maaboh sounds was corrected on pull request for #7979. And, Sky Destroyer does not seem to have any sound imperfections compared to PCB. So I want to remove the MACHINE_IMPERFECT_SOUND flag from the driver. (If you think I should not remove the flag, please review it) --- src/mame/drivers/cyclemb.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mame/drivers/cyclemb.cpp b/src/mame/drivers/cyclemb.cpp index 0d1a8fdec4db5..3c516fc6a2319 100644 --- a/src/mame/drivers/cyclemb.cpp +++ b/src/mame/drivers/cyclemb.cpp @@ -1160,5 +1160,5 @@ void cyclemb_state::init_skydest() // year name parent machine input class init rot company fullname flags -GAME( 1984, cyclemb, 0, cyclemb, cyclemb, cyclemb_state, init_cyclemb, ROT0, "Taito Corporation", "Cycle Maabou (Japan)", MACHINE_NO_COCKTAIL | MACHINE_IMPERFECT_SOUND | MACHINE_SUPPORTS_SAVE ) -GAME( 1985, skydest, 0, skydest, skydest, cyclemb_state, init_skydest, ROT0, "Taito Corporation", "Sky Destroyer (Japan)", MACHINE_NO_COCKTAIL | MACHINE_IMPERFECT_SOUND | MACHINE_SUPPORTS_SAVE ) +GAME( 1984, cyclemb, 0, cyclemb, cyclemb, cyclemb_state, init_cyclemb, ROT0, "Taito Corporation", "Cycle Maabou (Japan)", MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) +GAME( 1985, skydest, 0, skydest, skydest, cyclemb_state, init_skydest, ROT0, "Taito Corporation", "Sky Destroyer (Japan)", MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) From b125ee8c7e952e6b24366a875cea4e26dd1f40fa Mon Sep 17 00:00:00 2001 From: hap Date: Wed, 12 May 2021 19:48:24 +0200 Subject: [PATCH 2/2] update note --- src/mame/drivers/cyclemb.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mame/drivers/cyclemb.cpp b/src/mame/drivers/cyclemb.cpp index 3c516fc6a2319..5545e3f62f71d 100644 --- a/src/mame/drivers/cyclemb.cpp +++ b/src/mame/drivers/cyclemb.cpp @@ -10,10 +10,9 @@ appears to be in the exact middle between the gsword / josvolly HW and the ppkin driver by Angelo Salese TODO: -- separate driver into 2 classes -- reduce tagmap lookups -- sound (controlled by three i8741); -- coinage (controlled by i8741, like Gladiator / Ougon no Shiro); +- separate driver into 2 classes; +- reduce tagmap lookups; +- low-level emulation of inputs/soundlatch (controlled by several i8741, like Gladiator / Ougon no Shiro); - color prom resistor network is guessed, cyclemb yellows are more reddish on pcb video and photos; BTANB verified on pcb: cyclemb standing cones are reddish-yellow/black instead of red/white