configurable email subject #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jonbannister
left a comment
jonbannister
left a comment
There was a problem hiding this comment.
Looks good, but I think there is a small bug in the scheduler config - it doesn't seem to be saving the new field
danyaalm
reviewed
Jul 4, 2023
Comment on lines
27
to
31
| default_subject = f"Notebooker: {report_title} report completed with status: {result.status.value}" | ||
| if isinstance(result, NotebookResultComplete): | ||
| subject = result.email_subject or default_subject | ||
| else: | ||
| subject = default_subject |
Contributor
There was a problem hiding this comment.
Suggested change
| default_subject = f"Notebooker: {report_title} report completed with status: {result.status.value}" | |
| if isinstance(result, NotebookResultComplete): | |
| subject = result.email_subject or default_subject | |
| else: | |
| subject = default_subject | |
| subject = f"Notebooker: {report_title} report completed with status: {result.status.value}" | |
| if isinstance(result, NotebookResultComplete): | |
| subject = result.email_subject or subject |
Contributor
Author
There was a problem hiding this comment.
thanks, now changed
marcinapostoluk
force-pushed
the
133-add-option-to-customize-email-subject
branch
from
c49bab8 to
d31ac4e
Compare
Contributor
Author
hmmm re-tested and does work fine for me :/ |
added 2 commits
July 12, 2023 09:06
marcinapostoluk
force-pushed
the
133-add-option-to-customize-email-subject
branch
from
6983811 to
31bdb1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebooker already had an option to specify email subject but it was not possible to configure it via the UI. Now added and also preserving it in the results for re-runs