Fix whitespace-in-folder bug. Fixes #173 #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
from
fc0d203 to
90a5a33
Compare
jonbannister
commented
Apr 29, 2024
| } | ||
| return currentFolder | ||
| } | ||
| return decodeURI(currentFolder); |
Collaborator
Author
There was a problem hiding this comment.
This was the main culprit - the current folder had %20 etc. and so the results were incorrectly being filtered out.
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
from
90a5a33 to
848a594
Compare
…ts listed. Fixes #173. Create unit tests for index.js using Jest. Small refactor of index.js to use JS standards & apply Prettier.
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
from
848a594 to
76f7b25
Compare
Use a newer node version in 3.6 image.
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
from
68f0c0e to
82bbae8
Compare
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
6 times, most recently
from
d71ac16 to
a18dbdd
Compare
jonbannister
force-pushed
the
add-testing-fix-spaces
branch
from
a18dbdd to
bb626b5
Compare
danyaalm
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where folders with whitespace were unable to have their results listed. Fixes #173.
Create unit tests for index.js using Jest.
Small refactor of index.js to use JS standards & apply Prettier.