New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSocket Support #45

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@masonforest
Copy link
Collaborator

masonforest commented Oct 23, 2018

Allows clients to connect to nodes via WebSocket

Other changes:

  • Added request_id as an argument to BaseClient.post and all
    inherited modules

    We needed some way to associate responses with requests so we could
    send them back to the right pid. The request_id seemed well fit for
    this purpose.

Add WebSocket Support
Allows clients to connect to nodes via [WebSocket](https://tools.ietf.org/html/rfc6455)

Other changes:

* Added `request_id` as an argument to `BaseClient.post` and all
inherited modules

  We needed some way to associate responses with requests so we could
send them back to the right `pid`. The `request_id` seemed well fit for
this purpose.
@masonforest

This comment has been minimized.

Copy link
Collaborator

masonforest commented Oct 24, 2018

Closing this. Properly adding websocket support will take a significant amount of time and I'm too busy to take this on right now. If you need WebSocket support in EthereumEx and you don't mind using unstable software you can use this branch

@masonforest masonforest deleted the websocket-client branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment