Add WebSocket Support #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows clients to connect to nodes via [WebSocket](https://tools.ietf.org/html/rfc6455) Other changes: * Added `request_id` as an argument to `BaseClient.post` and all inherited modules We needed some way to associate responses with requests so we could send them back to the right `pid`. The `request_id` seemed well fit for this purpose.
|
Closing this. Properly adding websocket support will take a significant amount of time and I'm too busy to take this on right now. If you need WebSocket support in EthereumEx and you don't mind using unstable software you can use this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows clients to connect to nodes via WebSocket
Other changes:
Added
request_idas an argument toBaseClient.postand allinherited modules
We needed some way to associate responses with requests so we could
send them back to the right
pid. Therequest_idseemed well fit forthis purpose.