Repository navigation
Add a port of GTK3 and related dependencies - #169
Merged
Merged
Conversation
Merged
Member
Author
|
After some testing, we can ignore |
Dennisbonke
force-pushed
the
gtk3
branch
2 times, most recently
from
April 3, 2022 21:02
6d7afec to
e19e74f
Compare
Dennisbonke
marked this pull request as ready for review
April 3, 2022 21:02
avdgrinten
requested changes
Apr 5, 2022
avdgrinten
left a comment
avdgrinten
left a comment
Member
There was a problem hiding this comment.
Nothing major here but the funlockfile patches should be removed in favor of mlibc fixes.
Comment on lines
+71
to
+73
| - '-Werror=array-bounds', | ||
| + #'-Werror=array-bounds', |
Member
Author
There was a problem hiding this comment.
If I recall correctly, I got errors because of it. I'll recheck.
Member
Author
There was a problem hiding this comment.
A bunch of errors that look like this
../../../src/ports/gtk+-3/gtk/gtktextsegment.c:441:6: error: array subscript ‘GtkTextLineSegment {aka struct _GtkTextLineSegment}[0]’ is partly outside array bounds of ‘unsigned char[40]’ [-Werror=array-bounds]
441 | seg->body.toggle.inNodeCounts = 0;
| ^~
../../../src/ports/gtk+-3/gtk/gtktextsegment.c:431:9: note: referencing an object of size 40 allocated by ‘g_slice_alloc’
431 | seg = g_slice_alloc (TSEG_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Dennisbonke
force-pushed
the
gtk3
branch
2 times, most recently
from
April 16, 2022 14:10
f646abd to
a8329c2
Compare
Member
Author
|
Also blocked on managarm/mlibc#408, after that is fixed we can drop the |
Dennisbonke
force-pushed
the
gtk3
branch
4 times, most recently
from
October 10, 2022 14:24
8370b68 to
b8fb784
Compare
Dennisbonke
force-pushed
the
gtk3
branch
2 times, most recently
from
December 7, 2022 22:13
9977308 to
9339916
Compare
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits off the
gtk3part from #152. Several issues still remain, includingdbusnot working properly andgtk3missingpwrite(), potentially among other things.This PR adds the following ports:
libxslt,dbus,at-spi2-core,at-spi2-atk,gtk+-3.Blocked on #168 and a draft pending the things I mentioned above.
Blocked on #176