rust: port alacritty - #180
Merged
Merged
Conversation
Dennisbonke
requested changes
May 26, 2022
Dennisbonke
left a comment
Dennisbonke
left a comment
Member
There was a problem hiding this comment.
Some small things here and there, patches look fine to me.
64
marked this pull request as ready for review
May 27, 2022 21:35
Dennisbonke
reviewed
Jun 6, 2022
Dennisbonke
left a comment
Dennisbonke
left a comment
Member
There was a problem hiding this comment.
LGTM but some questions I'd like answers to before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the required libraries for alacritty, including some bits of nix and mio.
Blocked on a number of PRs (but ready to go once they're merged):