correct Content-Disposition header to conform to RFC 2183 … #1

Merged
merged 1 commit into from Feb 2, 2012

Conversation

Projects
None yet
2 participants
@rdefreitas
Contributor

rdefreitas commented Dec 14, 2011

date was not inside quoted string - was breaking Chrome 16 compatibility

RDeFreitas
correct Content-Disposition header to conform to RFC 2183
(date was not inside quoted string - was breaking Chrome 16 compatibility)
@@ -140,7 +140,7 @@ public virtual void Render(ViewContext viewContext, TextWriter writer)
response.ContentEncoding = ContentEncoding;
response.AppendHeader("X-Robots-Tag", "noindex, follow, noarchive, nosnippet");
- response.AppendHeader("Content-Disposition", String.Format(DispositionType + "; filename={0}.{1}; creation-date={2:r}", action, ContentFileExtension, DateTime.UtcNow));
+ response.AppendHeader("Content-Disposition", String.Format(DispositionType + "; filename={0}.{1}; creation-date=\"{2:r}\"", action, ContentFileExtension, DateTime.UtcNow));

This comment has been minimized.

Show comment Hide comment
@rdefreitas

rdefreitas Dec 14, 2011

Contributor

creation-date must be quoted to conform to RFC

@rdefreitas

rdefreitas Dec 14, 2011

Contributor

creation-date must be quoted to conform to RFC

@nberardi

This comment has been minimized.

Show comment Hide comment
@nberardi

nberardi Jan 22, 2012

Can you send a pull request, so I can update the NuGet and you can get credit for the fix.

Can you send a pull request, so I can update the NuGet and you can get credit for the fix.

This comment has been minimized.

Show comment Hide comment
@rdefreitas

rdefreitas Feb 2, 2012

Owner

I sent one same day as I did the commit :)

Owner

rdefreitas replied Feb 2, 2012

I sent one same day as I did the commit :)

This comment has been minimized.

Show comment Hide comment
@nberardi

nberardi Feb 2, 2012

nberardi added a commit that referenced this pull request Feb 2, 2012

Merge pull request #1 from rdefreitas/master
correct Content-Disposition header to conform to RFC 2183 …

@nberardi nberardi merged commit 1975e6e into managedfusion:master Feb 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment