Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Twig deprecations in tests #163

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@Kocal
Copy link
Contributor

Kocal commented Mar 13, 2019

Not an insane PR, but this should fix Twig deprecations in tests:
Sélection_396

Recently in Twig, class aliases (\Twig_Environment) have been deprecated for class namespaces (\Twig\Environment), refs:

@chalasr chalasr force-pushed the Kocal:chore/fix-twig-deprecations branch from 5ec9c79 to 23ca55f Mar 13, 2019

@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Mar 13, 2019

Good catch, thanks @Kocal.

@chalasr chalasr merged commit 23ca55f into manala:master Mar 13, 2019

1 check was pending

Scrutinizer Running
Details

chalasr added a commit that referenced this pull request Mar 13, 2019

bug #163 chore: fix Twig deprecations in tests (Kocal)
This PR was squashed before being merged into the master branch (closes #163).

Discussion
----------

chore: fix Twig deprecations in tests

Not an insane PR, but this should fix Twig deprecations in tests:
![Sélection_396](https://user-images.githubusercontent.com/2103975/54280328-7cf01d80-4597-11e9-8ae7-3082048e2ce9.png)

Recently in Twig, class aliases (`\Twig_Environment`) have been deprecated for class namespaces (`\Twig\Environment`), refs:
  - https://symfony.com/blog/new-in-twig-namespaced-classes
  - twigphp/Twig#2863
  - twigphp/Twig#2869
  - [changelog](https://github.com/twigphp/Twig/blob/2fe2f2d8bba055f78657b81d01ed588fd22d8cd3/CHANGELOG#L23)

Commits
-------

23ca55f chore: fix Twig deprecations in tests

@Kocal Kocal deleted the Kocal:chore/fix-twig-deprecations branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.