Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign EAF binding, introducing eaf-bind-key, support C-h m #96

Merged
merged 5 commits into from Nov 30, 2019
Merged

Redesign EAF binding, introducing eaf-bind-key, support C-h m #96

merged 5 commits into from Nov 30, 2019

Conversation

MatthewZMD
Copy link
Member

@MatthewZMD MatthewZMD commented Nov 30, 2019 •
edited

Now C-h m is able to display keybindings for EAF mode, fixes #82

New Function eaf-bind-key

(eaf-bind-key take_photo "p" eaf-camera-keybinding)
(eaf-bind-key scroll_up "C-n" eaf-pdfviewer-keybinding)

This allows user to modify EAF keybindings within their .emacs

@manateelazycat
Copy link
Member

提交新的补丁，不要去修改API的兼容性问题。这个是补丁提交大忌

请把按键和命令这两个参数调换一下，保持和原版的兼容性

@MatthewZMD
Copy link
Member Author

ok

@MatthewZMD
Copy link
Member Author

MatthewZMD commented Nov 30, 2019 •
edited

请把按键和命令这两个参数调换一下，保持和原版的兼容性

搞定!

@manateelazycat manateelazycat merged commit 0ee3407 into emacs-eaf:master Nov 30, 2019
@manateelazycat manateelazycat mentioned this pull request Nov 30, 2019
Closed
@stardiviner
Copy link
Contributor

@MatthewZMD :) very fast path. Great to saw this implemented.

@MatthewZMD MatthewZMD deleted the eaf-bind-key branch November 30, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

let eaf-open-camera support camera taking photograph
3 participants
@MatthewZMD @manateelazycat @stardiviner