New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Reorder list items #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
manderly
commented
Aug 27, 2020
- Adds a Spotify-inspired modal that allows the user to re-arrange the order of items
- Item order can be saved on a per-store basis, so items on the "Groceries" list can be in "ABCD" order for "Target" and "DCBA" order for "Fred Meyer"
- Refactored the use of streams so lists get updated automatically
…et user change selected store
… stream and use future builder instead
…o activeItems and totalItems so new items can be correctly placed in the default list
…by store list' feature
…t easier to maintain
…et item stream into two separate stream methods
… into listPositions map
…value when the user changes their store choice
…e making the db call for items
…on to track aggregate data
…t sort orders for different stores. So far it works but it doesn't update when returning from the reorder screen.
…g the main shopping list view
…d with their parent list. Removed some commented code chunks.
…d store list, which forces it to update on return
…0 to ensure it has a value when the main screen is drawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.