Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce message truncation #1279

Closed
flambard-took opened this issue May 18, 2019 · 0 comments
Closed

Reduce message truncation #1279

flambard-took opened this issue May 18, 2019 · 0 comments
Labels
enhancement normal
Milestone
Version 1.5.4

Comments

@flambard-took
Copy link
Member

We always truncate our log messages at 80 chars, which often leads to loss of information.

It's interesting to note, that Ctrl+P/message recall screen on the client already supports messages of arbitrary length, we just never get those through.

Sadly, the s2c PKT_MESSAGE packet defines messages as '%s' (limited to 80 chars), not '%S' (limited to MSG_LEN), so we'll need to break protocol (subtly).

Other points of interest:

  • the message recall sub-window should gain an ability to word-wrap
  • the chat message sub-window should also gain that ability
  • the topline message display should adapt some form of Angband "-more-" prompt to display longer messages
@flambard-took flambard-took added this to the Version 1.5.2 milestone May 18, 2019
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1276, copy the inventory fix to show_equip.
a9d5d9c 
Address #1279 ensure maximum available space is used in the
inven/equip prompts and subwindows.
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1279, change PKT_MESSAGE to use MSG_LEN %S format.
3c0a5f8 
This breaks protocol, but a backward-compatibility layer is
included, so previous versions of the client would still work.

This changeset add a new `client_version_atleast` function,
to check minimal client version, and `client_version_ok` has
been changed to utilize it.
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1279, change the way topline message is displayed.
6d0cde6 
Long messages that do not fit the screen can now be scrolled by pressing
the SPACE BAR key.
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1279, add "wrap_messages" option to word-wrap long messages
f747bd5 
in Message and Chat sub-windows.
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1279, handle "pgup"/"pgdn" keys in Ctrl+P message browser.
9ef3c17
flambard-took added a commit that referenced this issue May 18, 2019
@flambard-took
Address #1279, make allowed object name larger in have/see prompt.
dbd5591
flambard-took added a commit that referenced this issue May 22, 2019
@flambard-took
Address #1279, port "repeat last message" command (Ctrl+O) from V.
456677f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement normal
Projects
None yet
Milestone
Version 1.5.4
Development

No branches or pull requests
1 participant
@flambard-took