fix: update uninstall command to use remote-uninstall script and clarify messaging #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the uninstall process for LazyVim Docker to ensure a more comprehensive removal, aligning it with the behavior of the curl-based installation method. The changes primarily focus on improving clarity in messaging and replacing the uninstallation script with a more thorough alternative.
Updates to the uninstall process:
uninstalltarget now explicitly states it performs a "Complete uninstall" and uses theremote-uninstall.shscript instead of the previousuninstall-global-commands.shscript.scripts/install-global-commands.sh:lazy uninstallcommand to clarify that it performs a "Complete removal (same as curl method)." [1] [2] [3]uninstallcommand logic to invoke theremote-uninstall.shscript, ensuring a more thorough cleanup process. [1] [2]