Skip to content
Browse files

[11519] Fix player totem icons (those under player portrait)

SMSG_TOTEM_CREATED must be sent before totem added to map.

Signed-off-by: NoFantasy <nofantasy@nf.no>
  • Loading branch information...
1 parent b957b2b commit 9be593b8fa3124a8acb73dce38af8a76955e49f0 NoFantasy committed May 21, 2011
Showing with 4 additions and 3 deletions.
  1. +3 −2 src/game/SpellEffects.cpp
  2. +1 −1 src/shared/revision_nr.h
View
5 src/game/SpellEffects.cpp
@@ -7997,8 +7997,7 @@ void Spell::DoSummonTotem(SpellEffectIndex eff_idx, uint8 slot_dbc)
if (m_caster->IsFFAPvP())
pTotem->SetFFAPvP(true);
- pTotem->Summon(m_caster);
-
+ // sending SMSG_TOTEM_CREATED before add to map (done in Summon)
if (slot < MAX_TOTEM_SLOT && m_caster->GetTypeId() == TYPEID_PLAYER)
{
WorldPacket data(SMSG_TOTEM_CREATED, 1 + 8 + 4 + 4);
@@ -8008,6 +8007,8 @@ void Spell::DoSummonTotem(SpellEffectIndex eff_idx, uint8 slot_dbc)
data << uint32(m_spellInfo->Id);
((Player*)m_caster)->SendDirectMessage(&data);
}
+
+ pTotem->Summon(m_caster);
}
void Spell::EffectEnchantHeldItem(SpellEffectIndex eff_idx)
View
2 src/shared/revision_nr.h
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
- #define REVISION_NR "11518"
+ #define REVISION_NR "11519"
#endif // __REVISION_NR_H__

4 comments on commit 9be593b

@darkstalker

Nice one, this probably fixes TotemTimers addon as well.

@click
click commented on 9be593b May 21, 2011

@nofantasy: you may want to add this as well to get some bugs out of the way.... :)
TrinityCore/TrinityCore@c377848

(Well, at least something similar, I have no clue how you handle it in MaNGOS anymore)

@darkstalker

Totem summoning works fine on mangos

@tibbi
tibbi commented on 9be593b May 23, 2011

ye, summoning works fine. Also totem timers work already well, what a feeling to play a shamy :D thx

Please sign in to comment.
Something went wrong with that request. Please try again.