Errors in Bobuino pins_arduino.h

[oric-dan]

There are 4 problems in referenced file.

First, the following line should be changed to the one below:

define analogPinToChannel(p) ( (p) < NUM_ANALOG_INPUTS ? NUM_ANALOG_INPUTS - (p) : -1 )

define analogPinToChannel(p) ( (p) < NUM_ANALOG_INPUTS ? (NUM_ANALOG_INPUTS-1) - (p) : -1 )

Secondly, the following line produces a compile time error if you try to upload the
ArduinoISP sketch into a mighty-1284P bootloader chip using the Arduino IDE
with Board selection = Bobuino.

extern const uint8_t digital_pin_to_timer_PGM[NUM_DIGITAL_PINS];

It should be removed, or else the line ... #include "pins_arduino.h" ... should be
removed from the ArduinoISP sketch itself.

Thirdly, the line of item 2 also does not match the array being referenced, ie

const uint8_t PROGMEM digital_pin_to_timer_PGM[NUM_DIGITAL_PINS] = {...}

Fourthly, it also does not match the associated line in Arduino.h in the IDE directory:

extern const uint8_t PROGMEM digital_pin_to_timer_PGM[];