Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diffy.js for modern browsers #32

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@japsu
Copy link
Contributor

commented May 7, 2019

Failed to execute createObjectURL on URL: No function was found that matched the signature provided.

The createObjectURL API was changed in modern browsers some months ago in a backwards-incompatible way. This commit fixes the above error on modern browsers by forgoing createObjectURL entirely and instead doing videoEl.srcObject = stream.

https://stackoverflow.com/questions/27120757/failed-to-execute-createobjecturl-on-url
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/srcObject

fix error on createObjectURL
Failed to execute createObjectURL on URL: No function was found that matched the signature provided.

This commit fixes the above error on modern browsers.
@maniart

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Thanks for bringing to my attention. I'll Work on this shortly -- stay tuned!

@maniart maniart merged commit 1f5390a into maniart:master May 10, 2019

@maniart

This comment has been minimized.

Copy link
Owner

commented May 10, 2019

@japsu Thanks again -- published to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.