New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary has no icon #1

Closed
croxxx opened this Issue Jan 17, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@croxxx
Member

croxxx commented Jan 17, 2014

In previous versions the Binaries had an icon.
This is missing in latest release.

croxxx added a commit that referenced this issue Jul 17, 2015

@croxxx

This comment has been minimized.

Show comment
Hide comment
@croxxx

croxxx Aug 25, 2015

Member

Latest version (2015-08-22) seems to have some sort of icon displayed in taskbar:
2

Icon in explorer is still missing:
1

Member

croxxx commented Aug 25, 2015

Latest version (2015-08-22) seems to have some sort of icon displayed in taskbar:
2

Icon in explorer is still missing:
1

@joshi1999

This comment has been minimized.

Show comment
Hide comment
@joshi1999

joshi1999 Mar 6, 2016

Contributor

I'd tried to reproduce the bug:

  1. Downloaded Binary: No icon (taskbar and folder) (2015-10-14a)
  2. Recompiled the game, putted in a zip-folder, putted it out and tested: Normal icon (taskbar and folder) (Actually and 2015-10-14a)

croxxx: did you download the binary, or did you recompile it?

Contributor

joshi1999 commented Mar 6, 2016

I'd tried to reproduce the bug:

  1. Downloaded Binary: No icon (taskbar and folder) (2015-10-14a)
  2. Recompiled the game, putted in a zip-folder, putted it out and tested: Normal icon (taskbar and folder) (Actually and 2015-10-14a)

croxxx: did you download the binary, or did you recompile it?

@croxxx

This comment has been minimized.

Show comment
Hide comment
@croxxx

croxxx Mar 6, 2016

Member

I used the normal version back then but I'm quite certain it was a cached icon of some sort as I've seen that multiple times for different applications now.

Member

croxxx commented Mar 6, 2016

I used the normal version back then but I'm quite certain it was a cached icon of some sort as I've seen that multiple times for different applications now.

@MrRar

This comment has been minimized.

Show comment
Hide comment
@MrRar

MrRar Mar 12, 2016

Contributor

The icon is also missing from the Javascript version as well.
capture

Contributor

MrRar commented Mar 12, 2016

The icon is also missing from the Javascript version as well.
capture

croxxx added a commit that referenced this issue Mar 12, 2016

Update setup script
- Add "Manic Digger development team" as AppPublisher
- Install to program files folder by default
- Include german and french languages as they are also supported in the game
- Add ability to create a desktop shortcut that displays external icon. Workaround for #1
@croxxx

This comment has been minimized.

Show comment
Hide comment
@croxxx

croxxx Mar 12, 2016

Member

Web version updated in bcb4203
Installer should now create a desktop icon with proper image.

Member

croxxx commented Mar 12, 2016

Web version updated in bcb4203
Installer should now create a desktop icon with proper image.

croxxx added a commit that referenced this issue Apr 12, 2017

@croxxx croxxx self-assigned this Apr 12, 2017

@croxxx

This comment has been minimized.

Show comment
Hide comment
@croxxx

croxxx Apr 12, 2017

Member

Seems to be fixed with 1f20ace.
Compiled on Xubuntu 16.04, icon was displayed correctly on Windows 10.

Member

croxxx commented Apr 12, 2017

Seems to be fixed with 1f20ace.
Compiled on Xubuntu 16.04, icon was displayed correctly on Windows 10.

@croxxx croxxx closed this Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment