Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Support for .graphqls files. #89

Closed
martinlau opened this issue May 16, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@martinlau
Copy link

commented May 16, 2019

Describe the bug
Generally graphql queries and mutations are written as .graphql files, while schemas are .graphqls. Currently the GqlManifold only supports .gql and .graphql and so .graphqls files are ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Using the graphql sample application, rename movies.graphql to movies.graphqls
  2. Try to build the project
  3. Note compilation failures because the schema isn't included

Expected behavior
The project should work in the same way as it currently does with the schema named movies.graphql

Desktop (please complete the following information):

  • OS Type & Version: OSX 10.14.4 (although n/a)
  • Java/JDK version: 1.8 and 11
  • IntelliJ IDEA version: n/a
  • Manifold version: 0.65-alpha
  • Manifold IntelliJ plugin version: n/a

@rsmckinney rsmckinney added the bug label May 16, 2019

rsmckinney added a commit that referenced this issue May 16, 2019

Manifold GraphQL change (#89)
- support `graphqls` files
@martinlau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

Look at that turn around time! Awesome work :)

@rsmckinney

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Thanks for pointing that out! I hadn't known about that extension. Fix available in version 0.68-alpha, ij plugin release awaiting jetbrains approval, usually within 2 days. Cheers.

@rsmckinney rsmckinney closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.