New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom secret types. #20

merged 5 commits into from Jan 3, 2018


None yet
2 participants

jelmersnoeck commented Jan 2, 2018

This allows us to specify the type of secret we want to create in Kubernetes.

The first implementation provided here (apart from the default, Opaque) is the docker-registry type. This allows users to specify their docker registry credentials as a resource in Manifold and the CRD will load this as a correct docker-registry type, allowing users to pull images from private registries.

@jelmersnoeck jelmersnoeck self-assigned this Jan 2, 2018

@jelmersnoeck jelmersnoeck requested review from jbowes and enmand Jan 2, 2018


jbowes approved these changes Jan 3, 2018

awesome! 👍 on the docs and example

jelmersnoeck added some commits Jan 2, 2018

Teach our types about SecretType.
This will allow users to define which type of secret they want generated
from the credentials that get returned from their configuration.

Currently, we'll only support Opaque (default) and Docker Config.
Implement secrets type behaviour.
This adds logic to generate different kinds of content from the provided
credentials based on what the requested type is for the custom resource.

This currently only supports Opaque and Docker Config types.
Controller: make team optional.
A team can also be specified through the CRD itself.

@jelmersnoeck jelmersnoeck merged commit 0d4dc22 into jelmer-namespace-workload Jan 3, 2018

1 check passed

license/cla Contributor License Agreement is signed.

@jelmersnoeck jelmersnoeck deleted the jelmer-secret-type branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment